Use built-in Click functions where possible #67

New Issue

2020-01-08T09:40:11-05:00

JoshuaBoniface commented

2020-01-08 09:40:11 -05:00

(Migrated from git.bonifacelabs.ca)

#63 was first, using click.echo instead of a complex tempfile/manual editor call setup.

Investigate what other click utility functions might be useful.

#63 was first, using `click.echo` instead of a complex tempfile/manual editor call setup. Investigate what other click utility functions might be useful.

JoshuaBoniface commented

2020-01-08 09:40:29 -05:00

(Migrated from git.bonifacelabs.ca)

Candidate: click.echo_via_pager instead of manual less call in VM log.

Candidate: `click.echo_via_pager` instead of manual `less` call in VM log.

JoshuaBoniface commented

2020-01-08 09:41:46 -05:00

(Migrated from git.bonifacelabs.ca)

Candidate: click.confirm for in-line confirmation of potentially-messy operations. Currently includes most Ceph removal tasks; also include all other removal tasks (VM, network, template, etc.) along with a --yes option.

Candidate: `click.confirm` for in-line confirmation of potentially-messy operations. Currently includes most Ceph removal tasks; also include all other removal tasks (VM, network, template, etc.) along with a `--yes` option.

JoshuaBoniface commented

2020-01-08 09:43:09 -05:00

(Migrated from git.bonifacelabs.ca)

Candidate: click.progressbar for VM provisioning with a --wait flag similar to flush/unflush commands. Potentially implement this progressbar for flush/unflush as well.

Candidate: `click.progressbar` for VM provisioning with a `--wait` flag similar to flush/unflush commands. Potentially implement this progressbar for flush/unflush as well.

JoshuaBoniface commented

2020-01-08 09:44:59 -05:00

(Migrated from git.bonifacelabs.ca)

Candidate: click.pause for confirmation of some tasks - review for potential candidates.

Candidate: `click.pause` for confirmation of some tasks - review for potential candidates.

JoshuaBoniface commented

2020-01-08 10:07:20 -05:00

(Migrated from git.bonifacelabs.ca)

mentioned in commit 9e7d86d5cf

mentioned in commit 9e7d86d5cfdbf3e17f07d1eaca844abe818b0cd3

JoshuaBoniface commented

2020-01-08 10:34:54 -05:00

(Migrated from git.bonifacelabs.ca)

mentioned in commit c183bc7fef

mentioned in commit c183bc7fef94e5285e6fc959f45e45e9dcd3c4b5

JoshuaBoniface commented

2020-01-08 14:42:09 -05:00

(Migrated from git.bonifacelabs.ca)

mentioned in commit a197d9da80

mentioned in commit a197d9da8086ebff6a5097aeef3cb43b04419215

JoshuaBoniface commented

2020-01-08 17:26:46 -05:00

(Migrated from git.bonifacelabs.ca)

closed

JoshuaBoniface commented

2020-01-08 17:28:12 -05:00

(Migrated from git.bonifacelabs.ca)

Not implementing progress bar for the flush command since that would be a little gross to hack in (since the API supports the wait functionality, rather than just the CLI like with provisioning). Otherwise, all useful-looking Click special objects have been implemented.

Sign in to join this conversation.