parallelvirtualcluster/pvc
1
0
Fork 0
Code Issues 11 Pull Requests Projects Releases 115 Wiki Activity

Separate out pvcworkerd and pvchealthd into discrete packages #171

New Issue
Closed
opened 2023-11-26 03:44:17 -05:00 by joshuaboniface · 4 comments
joshuaboniface commented 2023-11-26 03:44:17 -05:00
Owner
Copy Link

As part of 0.9.81, pvcapid-worker was renamed pvcworkerd. However this is still tightly integrated into the api-daemon code tree.

Additionally #164 suggested separating out the node health monitoring portions into a pvchealthd, which too should be tracked in a separate code tree.

It would make a lot of sense to separate these into discrete Debian packages, and then have these two depended on by pvcnoded (pvc-daemon-node) rather than pvcapid (pvc-daemon-api).

I did make some initial attempts to separate out pvcworkerd, but these were somewhat unsuccessful. However I think another attempt is justified.

As part of 0.9.81, `pvcapid-worker` was renamed `pvcworkerd`. However this is still tightly integrated into the `api-daemon` code tree. Additionally #164 suggested separating out the node health monitoring portions into a `pvchealthd`, which too should be tracked in a separate code tree. It would make a lot of sense to separate these into discrete Debian packages, and then have these two depended on by `pvcnoded` (`pvc-daemon-node`) rather than `pvcapid` (`pvc-daemon-api`). I did make some initial attempts to separate out `pvcworkerd`, but these were somewhat unsuccessful. However I think another attempt is justified.
joshuaboniface commented 2023-11-26 03:50:56 -05:00
Author
Owner
Copy Link

Blocked by #172

Blocked by #172
joshuaboniface added the
blocked
 label 2023-11-26 03:52:17 -05:00
joshuaboniface added
API
Daemon
 and removed
blocked
 labels 2023-11-28 16:47:40 -05:00
joshuaboniface added this to the 1.0 milestone 2023-11-28 16:48:53 -05:00
joshuaboniface commented 2023-11-29 03:30:41 -05:00
Author
Owner
Copy Link

Initial PoC for pvchealthd was completed, and generally worked, but the code was lost due to a mistype. It did reveal scalability problems with node logging however, so that should be addressed first then reattempted.

Initial PoC for `pvchealthd` was completed, and generally worked, but the code was lost due to a mistype. It did reveal scalability problems with node logging however, so that should be addressed first then reattempted.
joshuaboniface commented 2023-11-29 21:19:23 -05:00
Author
Owner
Copy Link

Health monitoring successfully moved into standalone pvchealthd package and service. Seems to be working so far.

Next up is to move pvcworkerd in a similar way.

Health monitoring successfully moved into standalone `pvchealthd` package and service. Seems to be working so far. Next up is to move `pvcworkerd` in a similar way.
joshuaboniface commented 2023-11-30 03:30:44 -05:00
Author
Owner
Copy Link

pvcworkerd has been similarly ported to a separate package.

`pvcworkerd` has been similarly ported to a separate package.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
API
blocked
Issue blocked by another issue
bug
CLI
Client
Issues abut the client frontends
Daemon
Issues abut the node daemon
debt
Technical debt that should be investigated or cleaned up
documentation
feature
improvement
No Label
API
Daemon
Milestone
No items
No Milestone 1.0
Projects
Clear projects
No project
Assignees
Clear assignees
joshuaboniface
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: parallelvirtualcluster/pvc#171
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?