Add full VM snapshot support #153

New Issue

joshuaboniface · 2022-06-16T11:45:47-04:00

joshuaboniface commented

2022-06-16 11:45:47 -04:00

Libvirt and the RBD backend support full snapshots; implement them.

joshuaboniface added the

feature

label 2022-06-16 11:45:47 -04:00

joshuaboniface commented

2022-09-21 09:40:09 -04:00

It seems that libvirt does not suppor this for non-qcow2-backed systems at this time.

It would be possible though to simply implement this for all blockdevs attached to a VM to simplify that usecase, so we can do that instead.

It seems that libvirt does not suppor this for non-qcow2-backed systems at this time. It would be possible though to simply implement this for all blockdevs attached to a VM to simplify that usecase, so we can do that instead.

joshuaboniface started working 2022-09-21 09:40:11 -04:00

joshuaboniface stopped working 2022-09-21 09:40:21 -04:00

10s

joshuaboniface deleted spent time 2022-09-21 09:40:28 -04:00

- 10s

joshuaboniface commented

2022-10-08 00:15:56 -04:00

I think this could be done in a crude way by doing:

virsh pause on the VM
Quickly snapshotting all volumes
virsh unpause on the VM

It should be quick enough to be impreceptable given that RBD snapshots are basically instantaneous to create.

The collection of disk snapshots could then be saved/referenced by a "vm snapshot" database that ensures they could be used.

The big question comes from tasks beyond making the snapshot, like restoring from a snapshot. This is not something that has been implemented yet in PVC so doing so for individual RBD snapshots would be the best first step.

I think this could be done in a crude way by doing: 1. `virsh pause` on the VM 2. Quickly snapshotting all volumes 3. `virsh unpause` on the VM It should be quick enough to be impreceptable given that RBD snapshots are basically instantaneous to create. The collection of disk snapshots could then be saved/referenced by a "vm snapshot" database that ensures they could be used. The big question comes from tasks beyond *making* the snapshot, like restoring from a snapshot. This is not something that has been implemented yet in PVC so doing so for individual RBD snapshots would be the best first step.

joshuaboniface commented

2023-10-24 00:36:50 -04:00

This idea has been superseded by VM backups, which is more in line with the overall goals, and has now been implemented. Backup (including incremental backup) and restore is supported. This does require external storage of some kind, but provides a more robust option than simply snapshotting/rolling back snapshots.

joshuaboniface closed this issue

2023-10-24 00:36:50 -04:00

Sign in to join this conversation.