parallelvirtualcluster/pvc
1
0
Fork 0
Code Issues 11 Pull Requests Projects Releases 115 Wiki Activity

Add inplicit shutdown/stop to disable command #148

New Issue
Closed
opened 2021-11-04 14:49:21 -04:00 by joshuaboniface · 1 comment
joshuaboniface commented 2021-11-04 14:49:21 -04:00
Owner
Copy Link

It's a bit annoying to have to remember to set a VM as disable after stopping it or triggering a degraded cluster. It would be nice to go right to "disable" afterwards.

I can think of two ways to do this:

  1. Make pvc vm disable implicitly do a shutdown and add an explicit flag for stop i.e. --force or --stop.

  2. Make pvc vm shutdown and pvc vm stop take a --disable flag which then immediately sets the VM to disable.

Either way should be done on the API side with the corresponding CLI enhancement.

Not too sure which one is nicer, will have to think on it.

It's a bit annoying to have to remember to set a VM as `disable` after stopping it or triggering a degraded cluster. It would be nice to go right to "disable" afterwards. I can think of two ways to do this: 1. Make `pvc vm disable` implicitly do a `shutdown` and add an explicit flag for `stop` i.e. `--force` or `--stop`. 2. Make `pvc vm shutdown` and `pvc vm stop` take a `--disable` flag which then immediately sets the VM to disable. Either way should be done on the API side with the corresponding CLI enhancement. Not too sure which one is nicer, will have to think on it.
joshuaboniface added the
CLI
API
improvement
 labels 2021-11-04 14:49:21 -04:00
joshuaboniface self-assigned this 2021-11-04 14:49:21 -04:00
joshuaboniface commented 2021-11-06 03:33:59 -04:00
Author
Owner
Copy Link

I think 2 is the nicer way to do things.

Scratch that, since 2 is nearly impossible to implement with how states are transferred. Let's do 1 instead.

~~I think 2 is the nicer way to do things.~~ Scratch that, since 2 is nearly impossible to implement with how states are transferred. Let's do 1 instead.
joshuaboniface started working 2021-11-06 04:17:41 -04:00
joshuaboniface worked for 23s 2021-11-06 04:18:04 -04:00
joshuaboniface deleted spent time 2021-11-06 04:18:16 -04:00
- 23s
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
API
blocked
Issue blocked by another issue
bug
CLI
Client
Issues abut the client frontends
Daemon
Issues abut the node daemon
debt
Technical debt that should be investigated or cleaned up
documentation
feature
improvement
No Label
API
CLI
improvement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
joshuaboniface
No Assignees joshuaboniface
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: parallelvirtualcluster/pvc#148
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?