Add inplicit shutdown/stop to disable command #148

New Issue

joshuaboniface · 2021-11-04T14:49:21-04:00

joshuaboniface commented

2021-11-04 14:49:21 -04:00

It's a bit annoying to have to remember to set a VM as disable after stopping it or triggering a degraded cluster. It would be nice to go right to "disable" afterwards.

I can think of two ways to do this:

Make pvc vm disable implicitly do a shutdown and add an explicit flag for stop i.e. --force or --stop.
Make pvc vm shutdown and pvc vm stop take a --disable flag which then immediately sets the VM to disable.

Either way should be done on the API side with the corresponding CLI enhancement.

Not too sure which one is nicer, will have to think on it.

It's a bit annoying to have to remember to set a VM as `disable` after stopping it or triggering a degraded cluster. It would be nice to go right to "disable" afterwards. I can think of two ways to do this: 1. Make `pvc vm disable` implicitly do a `shutdown` and add an explicit flag for `stop` i.e. `--force` or `--stop`. 2. Make `pvc vm shutdown` and `pvc vm stop` take a `--disable` flag which then immediately sets the VM to disable. Either way should be done on the API side with the corresponding CLI enhancement. Not too sure which one is nicer, will have to think on it.

joshuaboniface added the

CLI

API

improvement

labels 2021-11-04 14:49:21 -04:00

joshuaboniface self-assigned this 2021-11-04 14:49:21 -04:00

joshuaboniface commented

2021-11-06 03:33:59 -04:00

~~I think 2 is the nicer way to do things.~~

Scratch that, since 2 is nearly impossible to implement with how states are transferred. Let's do 1 instead.

~~I think 2 is the nicer way to do things.~~ Scratch that, since 2 is nearly impossible to implement with how states are transferred. Let's do 1 instead.

joshuaboniface referenced this issue from a commit

2021-11-06 04:17:17 -04:00

Perform automatic shutdown/stop on VM disable

joshuaboniface referenced this issue from a commit

2021-11-06 04:17:17 -04:00

Add disable forcing to CLI

joshuaboniface started working 2021-11-06 04:17:41 -04:00

joshuaboniface closed this issue

2021-11-06 04:18:04 -04:00

joshuaboniface stopped working 2021-11-06 04:18:04 -04:00

23s

joshuaboniface deleted spent time 2021-11-06 04:18:16 -04:00