Revamp benchmarks to use fio JSON format #143

New Issue

joshuaboniface · 2021-10-02T00:36:51-04:00

JoshuaBoniface commented

2021-10-02 00:36:51 -04:00

(Migrated from git.bonifacelabs.ca)

When implementing Benchmarks I used a convoluted analysis and storage of certain aspects of the terse output format. However, this lost a lot of information, and it turns out that fio already had an in-built JSON output format. So we should switch to that instead.

This is a multipart migration:

Add a DB field in the Benchmark table to track the test version. 0 by default, 1 with the new version.
Return the test version field in the output of the API calls.
Reimplement the client formatting to handle whichever result is returned. That way clients can still see the legacy-formatted tests as well as new-formatted tests.
Add a --format output option to storage benchmark info to either format or dump the output.
Update to test format 1 and new options for tests including the new output version and some other tweaks.

While this is a fair bit of work for, admittedly, little benefit outside of the few clusters I already run, I don't think keeping the old codepaths is that big of a deal and the new version field will allow future format changes as well (for instance if we add new test types).

When implementing Benchmarks I used a convoluted analysis and storage of certain aspects of the `terse` output format. However, this lost a lot of information, and it turns out that `fio` already had an in-built JSON output format. So we should switch to that instead. This is a multipart migration: 1. Add a DB field in the Benchmark table to track the test version. `0` by default, `1` with the new version. 2. Return the test version field in the output of the API calls. 3. Reimplement the client formatting to handle whichever result is returned. That way clients can still see the legacy-formatted tests as well as new-formatted tests. 4. Add a `--format` output option to `storage benchmark info` to either format or dump the output. 5. Update to test format 1 and new options for tests including the new output version and some other tweaks. While this is a fair bit of work for, admittedly, little benefit outside of the few clusters I already run, I don't think keeping the old codepaths is that big of a deal and the new version field will allow future format changes as well (for instance if we add new test types).

JoshuaBoniface commented

2021-10-02 00:58:34 -04:00

(Migrated from git.bonifacelabs.ca)

changed the description

JoshuaBoniface commented

2021-10-02 00:59:16 -04:00

(Migrated from git.bonifacelabs.ca)

changed the description

JoshuaBoniface commented

2021-10-02 01:30:23 -04:00

(Migrated from git.bonifacelabs.ca)

1, 2, 3 and 4 are (mostly) implemented. The completion of 3 requires 5 to be completed so we know how to format it.