Refactor Daemon.py in Node daemon #131

New Issue

2021-06-17T02:39:41-04:00

JoshuaBoniface commented

2021-06-17 02:39:41 -04:00

(Migrated from git.bonifacelabs.ca)

The main Daemon.py module is extremely long and complex, and suffers from the "execute on import" issue.

Revamp the Daemon.py module to be more dynamic and simple, including splitting more functionality out to separate modules/files a la fencing.py. Additional improvement ideas include using multiprocessing to spawn the keepalive data collecting in a separate process (rather than a thread), as well as reordering some component to ensure optimal startup performance and consistency.

The main `Daemon.py` module is extremely long and complex, and suffers from the "execute on import" issue. Revamp the `Daemon.py` module to be more dynamic and simple, including splitting more functionality out to separate modules/files a la `fencing.py`. Additional improvement ideas include using multiprocessing to spawn the keepalive data collecting in a separate process (rather than a thread), as well as reordering some component to ensure optimal startup performance and consistency.

JoshuaBoniface commented

2021-07-11 23:00:43 -04:00

(Migrated from git.bonifacelabs.ca)

Due to the complex web of dependencies, this turned out to not be particularly easy, and I don't think it really achieves anything useful.

JoshuaBoniface commented

2021-07-11 23:00:44 -04:00

(Migrated from git.bonifacelabs.ca)

closed

Sign in to join this conversation.