Refactor Node daemon classes #128

New Issue

2021-06-08T00:55:36-04:00

JoshuaBoniface commented

2021-06-08 00:55:36 -04:00

(Migrated from git.bonifacelabs.ca)

Currently these classes were implemented ad-hoc as I learned Python. They need some serious cleanup and refactoring to get them to maintainable standards.

Leverage new knowledge about Classes (instance, class variables, class and static methods, etc.) to refactor these and ensure optimal clarity and maintainability.

Start with the NodeInstance class (and its related MetadataAPI and DNSAggregator classes) and proceed from there.

Currently these classes were implemented ad-hoc as I learned Python. They need some serious cleanup and refactoring to get them to maintainable standards. Leverage new knowledge about Classes (instance, class variables, class and static methods, etc.) to refactor these and ensure optimal clarity and maintainability. Start with the NodeInstance class (and its related MetadataAPI and DNSAggregator classes) and proceed from there.

JoshuaBoniface commented

2021-08-05 00:19:35 -04:00

(Migrated from git.bonifacelabs.ca)

mentioned in issue #136

JoshuaBoniface commented

2021-09-13 02:07:52 -04:00

(Migrated from git.bonifacelabs.ca)

Most of this has been completed.

The node Daemon.py was completely refactored and rewritten from scratch to split more elements into util/ modules, and rework some of the timing and control.

Mode of the daemon classes were untouched, since for the most part they work very well even after careful review, though some could be cleaned up slightly in the future.

Going to consider this one closed.

Most of this has been completed. The node Daemon.py was completely refactored and rewritten from scratch to split more elements into `util/` modules, and rework some of the timing and control. Mode of the daemon classes were untouched, since for the most part they work very well even after careful review, though some could be cleaned up slightly in the future. Going to consider this one closed.

JoshuaBoniface commented

2021-09-13 02:07:53 -04:00

(Migrated from git.bonifacelabs.ca)

closed

Sign in to join this conversation.