Refactor zkhander and Zookeeper handling behind class #127

New Issue

2021-05-27T22:07:03-04:00

JoshuaBoniface commented

2021-05-27 22:07:03 -04:00

(Migrated from git.bonifacelabs.ca)

Currently zkhandler is quite inconsistent between the 2 daemons, connections are managed manually, etc.

This could be greatly simplified by turning zkhandler into a class, then creating class instances of it (automatic connection) and then passing this around instead of zk_conn. This will also allow cleaner definitions of methods for the handler.

This is a fairly big rewrite/change so should be done on a feature branch.

Currently zkhandler is quite inconsistent between the 2 daemons, connections are managed manually, etc. This could be greatly simplified by turning zkhandler into a class, then creating class instances of it (automatic connection) and then passing this around instead of zk_conn. This will also allow cleaner definitions of methods for the handler. This is a fairly big rewrite/change so should be done on a feature branch.

JoshuaBoniface commented

2021-05-30 14:05:55 -04:00

(Migrated from git.bonifacelabs.ca)

Work completed. The API daemon now relies on the class-based ZKHandler, and specifically the decorator ZKConnection. This required a bit of refactoring around the loading of the config which works a bit nicer now.

JoshuaBoniface commented

2021-05-30 14:05:56 -04:00

(Migrated from git.bonifacelabs.ca)

closed

JoshuaBoniface commented

2021-05-30 14:06:01 -04:00

(Migrated from git.bonifacelabs.ca)

reopened

JoshuaBoniface commented

2021-05-30 14:06:26 -04:00

(Migrated from git.bonifacelabs.ca)

Next step is to port the main node daemon to use a similar configuration and avoid relying on its duplicated code.