More gracefully handle image/OVA file upload failures #121

New Issue

joshuaboniface · 2021-03-09T17:05:54-05:00

JoshuaBoniface commented

2021-03-09 17:05:54 -05:00

(Migrated from git.bonifacelabs.ca)

As it stands right now, if the image/OVA upload fails, specifically due to one of the conditional checks (e.g. at https://git.bonifacelabs.ca/parallelvirtualcluster/pvc/blob/master/api-daemon/pvcapid/helper.py#L1432), the response ends up triggering a 500/BrokenPipe exception on the client, since it is in the process of uploading the file when this error comes about, and HTTP/requests can't gracefully handle this.

Investigate alternative fixes here, including:

(a) chunking the sending
(b) a multi-stage upload (prepare, upload, finish)
(c) other options as they come up

As it stands right now, if the image/OVA upload fails, specifically due to one of the conditional checks (e.g. at https://git.bonifacelabs.ca/parallelvirtualcluster/pvc/blob/master/api-daemon/pvcapid/helper.py#L1432), the response ends up triggering a 500/BrokenPipe exception on the client, since it is in the process of uploading the file when this error comes about, and HTTP/`requests` can't gracefully handle this. Investigate alternative fixes here, including: (a) chunking the sending (b) a multi-stage upload (prepare, upload, finish) (c) other options as they come up

JoshuaBoniface commented

2021-05-19 16:56:54 -04:00

(Migrated from git.bonifacelabs.ca)

I feel like (b) might be the better option. It avoids having to refactor the already-fragile and hacky upload code, while still allowing us the ability to gracefully fail out of the initial steps.