Support CLI editing of VM details #101
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Some VM details should be easily editable from the CLI rather than requiring XML editing. Networks is the most obvious one since editing these and "generating" MACs is tedious, but this could also extend to several other common elements too, or eventually all aspects.
changed milestone to %4
Still consider this a nice-to-have feature, especially for networks. Would however require PVC to keep a model of the VM somehow, beyond the simple XML-only storage of today. I can see two potential implementations:
Pros: Easier to implement, Fewer unrelated code changes
Cons: Inflexible, Spaghettified code
Pros: Much more robust code, Abstracts libvirt configuration entirely, Potentially more flexibility (modules)
Cons: Extensive code rewrites, Complexity
mentioned in issue #93
Option 2 is actually infeasible while preserving the
pvc vm definefunctionality. That just leaves option 1, the parsing and setting of values.I can see a few elements where this sort of easy CLI editing will be extremely useful:
This should be easily implementable either by (a) subcommands to
pvc vm modify(e.g.pvc vm modify vcpu), which will require reworking of the existingpvc vm modifycommand, or (b) a set of new subcommands for each element (e.g.pvc vm vcpu <subcommand>, with subcommands likegetandmodify).I think option (b) is nicer long-term and provides far more flexibility.
mentioned in commit 9f1dd3540445e3cf40046de8e858101c7e979461
mentioned in commit 3ad093d363ec30753165d870064821f6d1bc057d
mentioned in commit 7cec2fa1ad6baac3f6f6dfae16529577b62c874a
Elements 1 and 2 (vCPU and memory) are done. Element 5 will probably be next as this is similarly easy. Elements 3 and 4 are more complex.
mentioned in commit 4f2f46c68dfa3a2397d5409c7ff376b86a68e815
Decided to abandon element 5. It is hard enough and also rare enough to not really justify this.
mentioned in commit e7037e4e1423f2eb5d17c270cb9e8fe1e518ad68
mentioned in commit 1f040031c7b41785368e5972546c7c8226597e04
mentioned in commit cf57c54475cd6ed15ecffaf04bb1f8c21ad2b2fe
mentioned in commit
5f5f4dd421mentioned in commit
03d4be79b7mentioned in commit
569dcd84a4mentioned in commit
1ff5d8bf46mentioned in commit
18d3fc8431mentioned in commit
b72c415bf1mentioned in commit
9c339f4191closed via commit
a4536c31d4