Bump version to 0.9.90

Fix possible race condition applying schemas
Found an instance where two of these fired too close together, and caused a fatal error. Use a write lock, and then catch the schema.apply function in case it fails anyways.
2024-01-11 10:21:06 -05:00 · 2024-01-11 10:21:01 -05:00 · 2024-01-11 10:20:42 -05:00 · 2024-01-11 10:20:33 -05:00
14 changed files with 31 additions and 4815 deletions
--- a/.version
+++ b/.version
@ -1 +1 @@
-0.9.89
+0.9.90
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -1,5 +1,12 @@
 ## PVC Changelog

+###### [v0.9.90](https://github.com/parallelvirtualcluster/pvc/releases/tag/v0.9.90)
+
+  * [Client CLI/API Daemon] Adds additional backup metainfo and an emailed report option to autobackups.
+  * [All] Adds a live migration maximum downtime selector to help with busy VM migrations.
+  * [API Daemon] Fixes a database migration bug on Debian 11.
+  * [Node Daemon] Fixes a race condition when applying Zookeeper schema changes.
+
 ###### [v0.9.89](https://github.com/parallelvirtualcluster/pvc/releases/tag/v0.9.89)

  * [API/Worker Daemons] Fixes a bug with the Celery result backends not being properly initialized on Debian 10/11.
--- a/api-daemon/pvc-api-db-upgrade
+++ b/api-daemon/pvc-api-db-upgrade
@ -12,16 +12,7 @@ fi

 pushd /usr/share/pvc

-case "$( cat /etc/debian_version )" in
-    10.*|11.*)
-        # Debian 10 & 11
-        ./pvcapid-manage_legacy.py db upgrade
-    ;;
-    *)
-        # Debian 12+
-        export FLASK_APP=./pvcapid-manage_flask.py
-        flask db upgrade
-    ;;
-esac
+export FLASK_APP=./pvcapid-manage-flask.py
+flask db upgrade

 popd
--- a/api-daemon/pvcapid-manage-flask.py
+++ b/api-daemon/pvcapid-manage-flask.py
--- a/api-daemon/pvcapid-manage_legacy.py
+++ b/api-daemon/pvcapid-manage_legacy.py
@ -1,33 +0,0 @@
-#!/usr/bin/env python3
-
-# pvcapid-manage_legacy.py - PVC Database management tasks (Legacy)
-# Part of the Parallel Virtual Cluster (PVC) system
-#
-#    Copyright (C) 2018-2024 Joshua M. Boniface <joshua@boniface.me>
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation, version 3.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License
-#    along with this program.  If not, see <https://www.gnu.org/licenses/>.
-#
-###############################################################################
-
-from flask_migrate import Migrate, MigrateCommand, Manager
-
-from pvcapid.flaskapi import app, db
-from pvcapid.models import *  # noqa F401,F403
-
-migrate = Migrate(app, db)
-manager = Manager(app)
-
-manager.add_command("db", MigrateCommand)
-
-if __name__ == "__main__":
-    manager.run()
--- a/api-daemon/pvcapid/Daemon.py
+++ b/api-daemon/pvcapid/Daemon.py
@ -27,7 +27,7 @@ from distutils.util import strtobool as dustrtobool
 import daemon_lib.config as cfg

 # Daemon version
-version = "0.9.89"
+version = "0.9.90"

 # API version
 API_VERSION = 1.0
--- a/api-daemon/swagger.html
+++ b/api-daemon/swagger.html
@ -1,13 +0,0 @@
-<!DOCTYPE html>
-<html>
-  <head>
-    <title>PVC Client API Documentation</title>
-    <meta charset="utf-8"/>
-    <meta name="viewport" content="width=device-width, initial-scale=1">
-    <style> body { margin: 0; padding: 0; } </style>
-  </head>
-  <body>
-    <redoc spec-url='./swagger.json' hide-loading></redoc>
-    <script src="https://rebilly.github.io/ReDoc/releases/latest/redoc.min.js"> </script>
-  </body>
-</html>
--- a/api-daemon/swagger.json
+++ b/api-daemon/swagger.json
--- a/client-cli/setup.py
+++ b/client-cli/setup.py
@ -2,7 +2,7 @@ from setuptools import setup

 setup(
    name="pvc",
-    version="0.9.89",
+    version="0.9.90",
    packages=["pvc.cli", "pvc.lib"],
    install_requires=[
        "Click",
--- a/debian/changelog
+++ b/debian/changelog
@ -1,3 +1,12 @@
+pvc (0.9.90-0) unstable; urgency=high
+
+  * [Client CLI/API Daemon] Adds additional backup metainfo and an emailed report option to autobackups.
+  * [All] Adds a live migration maximum downtime selector to help with busy VM migrations.
+  * [API Daemon] Fixes a database migration bug on Debian 11.
+  * [Node Daemon] Fixes a race condition when applying Zookeeper schema changes.
+
+ -- Joshua M. Boniface <joshua@boniface.me>  Thu, 11 Jan 2024 00:14:49 -0500
+
 pvc (0.9.89-0) unstable; urgency=high

  * [API/Worker Daemons] Fixes a bug with the Celery result backends not being properly initialized on Debian 10/11.
--- a/health-daemon/pvchealthd/Daemon.py
+++ b/health-daemon/pvchealthd/Daemon.py
@ -33,7 +33,7 @@ import os
 import signal

 # Daemon version
-version = "0.9.89"
+version = "0.9.90"


 ##########################################################
--- a/node-daemon/pvcnoded/Daemon.py
+++ b/node-daemon/pvcnoded/Daemon.py
@ -49,7 +49,7 @@ import re
 import json

 # Daemon version
-version = "0.9.89"
+version = "0.9.90"


 ##########################################################
@ -197,7 +197,9 @@ def entrypoint():
        os.execv(sys.argv[0], sys.argv)

    # Validate the schema
-    pvcnoded.util.zookeeper.validate_schema(logger, zkhandler)
+    with zkhandler.writelock("base.schema.version"):
+        sleep(0.5)
+        pvcnoded.util.zookeeper.validate_schema(logger, zkhandler)

    # Define a cleanup function
    def cleanup(failure=False):
--- a/node-daemon/pvcnoded/util/zookeeper.py
+++ b/node-daemon/pvcnoded/util/zookeeper.py
@ -94,7 +94,10 @@ def validate_schema(logger, zkhandler):
    # Validate our schema against the active version
    if not zkhandler.schema.validate(zkhandler, logger):
        logger.out("Found schema violations, applying", state="i")
-        zkhandler.schema.apply(zkhandler)
+        try:
+            zkhandler.schema.apply(zkhandler)
+        except Exception as e:
+            logger.out(f"Failed to apply schema updates: {e}", state="w")
    else:
        logger.out("Schema successfully validated", state="o")

--- a/worker-daemon/pvcworkerd/Daemon.py
+++ b/worker-daemon/pvcworkerd/Daemon.py
@ -44,7 +44,7 @@ from daemon_lib.vmbuilder import (
 )

 # Daemon version
-version = "0.9.89"
+version = "0.9.90"


 config = cfg.get_configuration()
Author	SHA1	Message	Date
Joshua M. Boniface	d07770eebe	Bump version to 0.9.90	2024-01-11 10:21:06 -05:00
Joshua M. Boniface	a5763c9d25	Fix possible race condition applying schemas Found an instance where two of these fired too close together, and caused a fatal error. Use a write lock, and then catch the schema.apply function in case it fails anyways.	2024-01-11 10:21:01 -05:00
Joshua M. Boniface	39ec427c42	Remove obsolete swagger files	2024-01-11 10:20:42 -05:00
Joshua M. Boniface	1ba21312ea	Use flask manage for all versions The legacy method does not work any longer, so just use the Flask manage script and remove the obsolete legacy one.	2024-01-11 10:20:33 -05:00
 @ -1 +1 @@
 .9.89
 .9.90