parallelvirtualcluster
/
pvc
1
0
Fork 0
Code Issues 11 Pull Requests Projects Releases 111 Wiki Activity

Use string format() consistently

This commit is contained in:
Joshua Boniface 2018-06-06 21:54:38 -04:00
parent 155e48ce94
commit f4bdc22602
1 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
VMInstance.py
View File

@ -26,7 +26,7 @@ class VMInstance:
def __init__(self, domuuid, zk, thishypervisor): def __init__(self, domuuid, zk, thishypervisor):
# Passed-in variables on creation # Passed-in variables on creation
self.domuuid = domuuid self.domuuid = domuuid
self.zkey = '/domains/%s' % domuuid self.zkey = '/domains/{}'.format(domuuid)
self.zk = zk self.zk = zk
self.thishypervisor = thishypervisor self.thishypervisor = thishypervisor
@ -68,21 +68,21 @@ class VMInstance:
# Start up the VM # Start up the VM
def start_vm(self, xmlconfig): def start_vm(self, xmlconfig):
print(">>> %s - Starting VM" % self.domuuid) print(">>> {} - Starting VM.".format(self.domuuid))
self.instart = True self.instart = True
# Start up a new Libvirt connection # Start up a new Libvirt connection
libvirt_name = "qemu:///system" libvirt_name = "qemu:///system"
conn = libvirt.open(libvirt_name) conn = libvirt.open(libvirt_name)
if conn == None: if conn == None:
print('>>> %s - Failed to open local libvirt connection.' % self.domuuid) print('>>> {} - Failed to open local libvirt connection.'.format(self.domuuid))
self.instart = False self.instart = False
return return
try: try:
dom = conn.createXML(xmlconfig, 0) dom = conn.createXML(xmlconfig, 0)
except libvirt.libvirtError as e: except libvirt.libvirtError as e:
print('>>> %s - Failed to create VM' % self.domuuid) print('>>> {} - Failed to create VM.'.format(self.domuuid))
self.zk.set(self.zkey + '/state', 'stop'.encode('ascii')) self.zk.set(self.zkey + '/state', 'stop'.encode('ascii'))
if not self.domuuid in self.thishypervisor.domain_list: if not self.domuuid in self.thishypervisor.domain_list:
@ -94,7 +94,7 @@ class VMInstance:
# Stop the VM forcibly without updating state # Stop the VM forcibly without updating state
def terminate_vm(self): def terminate_vm(self):
print(">>> %s - Terminating VM" % self.domuuid) print(">>> {} - Terminating VM.".format(self.domuuid))
self.instop = True self.instop = True
try: try:
self.dom.destroy() self.dom.destroy()
@ -108,7 +108,7 @@ class VMInstance:
# Stop the VM forcibly # Stop the VM forcibly
def stop_vm(self): def stop_vm(self):
print(">>> %s - Forcibly stopping VM" % self.domuuid) print(">>> {} - Forcibly stopping VM.".format(self.domuuid))
self.instop = True self.instop = True
try: try:
self.dom.destroy() self.dom.destroy()
@ -126,7 +126,7 @@ class VMInstance:
# Shutdown the VM gracefully # Shutdown the VM gracefully
def shutdown_vm(self): def shutdown_vm(self):
print(">>> %s - Gracefully stopping VM" % self.domuuid) print(">>> {} - Gracefully stopping VM.".format(self.domuuid))
self.inshutdown = True self.inshutdown = True
self.dom.shutdown() self.dom.shutdown()
try: try:
@ -136,7 +136,7 @@ class VMInstance:
time.sleep(0.5) time.sleep(0.5)
if tick >= 60: if tick >= 60:
print(">>> %s - Shutdown timeout expired" % self.domuuid) print(">>> {} - Shutdown timeout expired.".format(self.domuuid))
self.stop_vm() self.stop_vm()
self.inshutdown = False self.inshutdown = False
return return
@ -155,18 +155,18 @@ class VMInstance:
def live_migrate_vm(self, dest_hypervisor): def live_migrate_vm(self, dest_hypervisor):
try: try:
dest_conn = libvirt.open('qemu+tcp://%s/system' % self.hypervisor) dest_conn = libvirt.open('qemu+tcp://{}/system'.format(self.hypervisor))
if dest_conn == None: if dest_conn == None:
raise raise
except: except:
print('>>> %s - Failed to open connection to qemu+tcp://%s/system; aborting migration' % self.hypervisor) print('>>> {} - Failed to open connection to qemu+tcp://{}/system; aborting migration.'.format(self.dom_uuid, self.hypervisor))
return 1 return 1
try: try:
target_dom = self.dom.migrate(dest_conn, libvirt.VIR_MIGRATE_LIVE, None, None, 0) target_dom = self.dom.migrate(dest_conn, libvirt.VIR_MIGRATE_LIVE, None, None, 0)
if target_dom == None: if target_dom == None:
raise raise
print('>>> %s - Migrated successfully' % self.domuuid) print('>>> {} - Migrated successfully.'.format(self.domuuid))
except: except:
dest_conn.close() dest_conn.close()
return 1 return 1
@ -178,12 +178,13 @@ class VMInstance:
def migrate_vm(self): def migrate_vm(self):
self.inmigrate = True self.inmigrate = True
print('>>> %s - Migrating VM to %s' % (self.domuuid, self.hypervisor)) print('>>> {} - Migrating VM to hypervisor "{}".'.format(self.domuuid, self.hypervisor))
migrate_ret = self.live_migrate_vm(self.hypervisor) migrate_ret = self.live_migrate_vm(self.hypervisor)
if migrate_ret != 0: if migrate_ret != 0:
print('>>> %s - Could not live migrate VM; shutting down instead' % self.domuuid) print('>>> {} - Could not live migrate VM; shutting down to migrate instead.'.format(self.domuuid))
self.shutdown_vm() self.shutdown_vm()
time.sleep(0.5) time.sleep(1)
self.zk.set(self.zkey + '/state', 'start'.encode('ascii'))
else: else:
try: try:
self.thishypervisor.domain_list.remove(self.domuuid) self.thishypervisor.domain_list.remove(self.domuuid)
@ -194,7 +195,7 @@ class VMInstance:
# Receive the migration from another host (wait until VM is running) # Receive the migration from another host (wait until VM is running)
def receive_migrate(self): def receive_migrate(self):
print('>>> %s - Receiving migration' % self.domuuid) print('>>> {} - Receiving migration.'.format(self.domuuid))
self.inreceive = True self.inreceive = True
while True: while True:
self.dom = lookupByUUID(self.domuuid) self.dom = lookupByUUID(self.domuuid)
@ -209,7 +210,7 @@ class VMInstance:
if not self.domuuid in self.thishypervisor.domain_list: if not self.domuuid in self.thishypervisor.domain_list:
self.thishypervisor.domain_list.append(self.domuuid) self.thishypervisor.domain_list.append(self.domuuid)
print('>>> %s - Migrated successfully' % self.domuuid) print('>>> {} - Migrated successfully.'.format(self.domuuid))
self.inreceive = False self.inreceive = False
# #
@ -274,7 +275,7 @@ def lookupByUUID(tuuid):
# Open a libvirt connection # Open a libvirt connection
conn = libvirt.open(libvirt_name) conn = libvirt.open(libvirt_name)
if conn == None: if conn == None:
print('>>> %s - Failed to open local libvirt connection.' % self.domuuid) print('>>> {} - Failed to open local libvirt connection.'.format(self.domuuid))
return dom return dom
# Lookup the UUID # Lookup the UUID