parallelvirtualcluster/pvc
1
0
Fork 0
Code Issues 11 Pull Requests Projects Releases 113 Wiki Activity

Catch errors if snapshot fails to remove

Browse Source 
A missing snapshot could cause an exception here which would break the
entire autobackup run. Catch the exception and continue on as this
should never be a fatal situation.
This commit is contained in:
Joshua Boniface 2025-02-10 16:33:44 -05:00
parent 309b203f5d
commit d695e855f9
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
daemon-common/autobackup.py
View File

@ -469,15 +469,16 @@ def run_vm_backup(zkhandler, celery, config, vm_detail, force_full=False):
if len(marked_for_deletion) > 0: if len(marked_for_deletion) > 0:
for backup_to_delete in marked_for_deletion: for backup_to_delete in marked_for_deletion:
ret = vm.vm_worker_remove_snapshot( try:
zkhandler, None, vm_name, backup_to_delete["snapshot_name"] ret = vm.vm_worker_remove_snapshot(
) zkhandler, None, vm_name, backup_to_delete["snapshot_name"]
if ret is False: )
error_message = f"Failed to remove obsolete backup snapshot '{backup_to_delete['snapshot_name']}', leaving in tracked backups" except Exception:
error_message = f"Failed to remove obsolete backup snapshot '{backup_to_delete['snapshot_name']}', removing from tracked backups anyways"
log_err(celery, error_message) log_err(celery, error_message)
else:
rmtree(f"{vm_backup_path}/{backup_to_delete['snapshot_name']}") rmtree(f"{vm_backup_path}/{backup_to_delete['snapshot_name']}")
tracked_backups.remove(backup_to_delete) tracked_backups.remove(backup_to_delete)
tracked_backups = update_tracked_backups() tracked_backups = update_tracked_backups()
return tracked_backups return tracked_backups