Lint: E712 comparison to True should be 'if cond is True:' or 'if cond:'

This commit is contained in:
Joshua Boniface 2020-11-06 19:35:19 -05:00
parent fb4aafcea9
commit 72ae149cf1
3 changed files with 8 additions and 8 deletions

View File

@ -340,7 +340,7 @@ def format_info(config, domain_information, long_output):
ainformation.append('{}vCPUs:{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['vcpu'])) ainformation.append('{}vCPUs:{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['vcpu']))
ainformation.append('{}Topology (S/C/T):{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['vcpu_topology'])) ainformation.append('{}Topology (S/C/T):{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['vcpu_topology']))
if long_output == True: if long_output is True:
# Virtualization information # Virtualization information
ainformation.append('') ainformation.append('')
ainformation.append('{}Emulator:{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['emulator'])) ainformation.append('{}Emulator:{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['emulator']))
@ -435,7 +435,7 @@ def format_info(config, domain_information, long_output):
ainformation.append('') ainformation.append('')
ainformation.append('{}Networks:{} {}'.format(ansiprint.purple(), ansiprint.end(), ', '.join(net_list))) ainformation.append('{}Networks:{} {}'.format(ansiprint.purple(), ansiprint.end(), ', '.join(net_list)))
if long_output == True: if long_output is True:
# Disk list # Disk list
ainformation.append('') ainformation.append('')
name_length = 0 name_length = 0

View File

@ -145,7 +145,7 @@ if not os.path.isfile(store_path + '/pvc-cli.json'):
CONTEXT_SETTINGS = dict(help_option_names=['-h', '--help'], max_content_width=120) CONTEXT_SETTINGS = dict(help_option_names=['-h', '--help'], max_content_width=120)
def cleanup(retcode, retmsg): def cleanup(retcode, retmsg):
if retcode == True: if retcode is True:
if retmsg != '': if retmsg != '':
click.echo(retmsg) click.echo(retmsg)
exit(0) exit(0)
@ -692,7 +692,7 @@ def vm_modify(domain, cfgfile, editor, restart):
dom_uuid = vm_information.get('uuid') dom_uuid = vm_information.get('uuid')
dom_name = vm_information.get('name') dom_name = vm_information.get('name')
if editor == True: if editor is True:
# Grab the current config # Grab the current config
current_vm_cfg_raw = vm_information.get('xml') current_vm_cfg_raw = vm_information.get('xml')
xml_data = etree.fromstring(current_vm_cfg_raw) xml_data = etree.fromstring(current_vm_cfg_raw)
@ -2897,7 +2897,7 @@ def provisioner_userdata_modify(name, filename, editor):
if editor == False and filename == None: if editor == False and filename == None:
cleanup(False, 'Either a file or the "--editor" option must be specified.') cleanup(False, 'Either a file or the "--editor" option must be specified.')
if editor == True: if editor is True:
# Grab the current config # Grab the current config
retcode, retdata = pvc_provisioner.userdata_info(config, name) retcode, retdata = pvc_provisioner.userdata_info(config, name)
if not retcode: if not retcode:
@ -3076,7 +3076,7 @@ def provisioner_script_modify(name, filename, editor):
if editor == False and filename == None: if editor == False and filename == None:
cleanup(False, 'Either a file or the "--editor" option must be specified.') cleanup(False, 'Either a file or the "--editor" option must be specified.')
if editor == True: if editor is True:
# Grab the current config # Grab the current config
retcode, retdata = pvc_provisioner.script_info(config, name) retcode, retdata = pvc_provisioner.script_info(config, name)
if not retcode: if not retcode:

View File

@ -730,7 +730,7 @@ def format_info(zk_conn, domain_information, long_output):
ainformation.append('{}vCPUs:{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['vcpu'])) ainformation.append('{}vCPUs:{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['vcpu']))
ainformation.append('{}Topology (S/C/T):{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['vcpu_topology'])) ainformation.append('{}Topology (S/C/T):{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['vcpu_topology']))
if long_output == True: if long_output is True:
# Virtualization information # Virtualization information
ainformation.append('') ainformation.append('')
ainformation.append('{}Emulator:{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['emulator'])) ainformation.append('{}Emulator:{} {}'.format(ansiprint.purple(), ansiprint.end(), domain_information['emulator']))
@ -804,7 +804,7 @@ def format_info(zk_conn, domain_information, long_output):
ainformation.append('') ainformation.append('')
ainformation.append('{}Networks:{} {}'.format(ansiprint.purple(), ansiprint.end(), ', '.join(net_list))) ainformation.append('{}Networks:{} {}'.format(ansiprint.purple(), ansiprint.end(), ', '.join(net_list)))
if long_output == True: if long_output is True:
# Disk list # Disk list
ainformation.append('') ainformation.append('')
name_length = 0 name_length = 0