parallelvirtualcluster
/
pvc
1
0
Fork 0
Code Issues 11 Pull Requests Projects Releases 111 Wiki Activity

Correct error handling if monitoring plugins fail

This commit is contained in:
Joshua Boniface 2023-02-23 22:28:34 -05:00
parent 8667f4d03b
commit 202dc3ed59
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
node-daemon/pvcnoded/objects/MonitoringInstance.py
View File

@ -332,7 +332,15 @@ class MonitoringInstance(object):
def run_plugin(self, plugin): def run_plugin(self, plugin):
time_start = datetime.now() time_start = datetime.now()
result = plugin.run() try:
result = plugin.run()
except Exception as e:
self.logger.out(
f"Monitoring plugin {plugin.plugin_name} failed: {type(e).__name__}: {e}",
state="e",
)
# Whatever it had, we try to return
return plugin.plugin_result
time_end = datetime.now() time_end = datetime.now()
time_delta = time_end - time_start time_delta = time_end - time_start
runtime = "{:0.02f}".format(time_delta.total_seconds()) runtime = "{:0.02f}".format(time_delta.total_seconds())
@ -363,8 +371,7 @@ class MonitoringInstance(object):
state="t", state="t",
prefix=f"{result.plugin_name} ({result.runtime}s)", prefix=f"{result.plugin_name} ({result.runtime}s)",
) )
if result is not None: total_health -= result.health_delta
total_health -= result.health_delta
if total_health < 0: if total_health < 0:
total_health = 0 total_health = 0