parallelvirtualcluster/pvc
1
0
Fork 0
Code Issues 11 Pull Requests Projects Releases 115 Wiki Activity

Add guard rails against manipulating mirrors

Browse Source 
Snapshot mirrors should normally be promoted using "mirror promote", and
not started manually. This adds guard rails against that to the "start",
"stop", and "disable" state commands to prevent changing mirror states
without an explicit "--force" option.
This commit is contained in:
Joshua Boniface
2024-10-08 23:51:48 -04:00
parent 3ea7421f09
commit 1d90b066bc
5 changed files with 59 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
api-daemon/pvcapid/helper.py
View File

@ -1153,11 +1153,11 @@ def vm_remove(zkhandler, name):
@ZKConnection(config)
def vm_start(zkhandler, name):
def vm_start(zkhandler, name, force=False):
"""
Start a VM in the PVC cluster.
"""
retflag, retdata = pvc_vm.start_vm(zkhandler, name)
retflag, retdata = pvc_vm.start_vm(zkhandler, name, force=force)
if retflag:
retcode = 200
@ -1201,11 +1201,11 @@ def vm_shutdown(zkhandler, name, wait):
@ZKConnection(config)
def vm_stop(zkhandler, name):
def vm_stop(zkhandler, name, force=False):
"""
Forcibly stop a VM in the PVC cluster.
"""
retflag, retdata = pvc_vm.stop_vm(zkhandler, name)
retflag, retdata = pvc_vm.stop_vm(zkhandler, name, force=force)
if retflag:
retcode = 200
@ -1219,7 +1219,7 @@ def vm_stop(zkhandler, name):
@ZKConnection(config)
def vm_disable(zkhandler, name, force=False):
"""
Disable (shutdown or force stop if required)a VM in the PVC cluster.
Disable (shutdown or force stop if required) a VM in the PVC cluster.
"""
retflag, retdata = pvc_vm.disable_vm(zkhandler, name, force=force)