parallelvirtualcluster
/
pvc
1
0
Fork 0
Code Issues 11 Pull Requests Projects Releases 109 Wiki Activity

Bump IPMI timeout to 2 seconds

This commit is contained in:
Joshua Boniface 2023-02-25 03:41:37 -05:00
parent 7c07fbefff
commit 0b583bfdaf
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/manuals/health-plugins.md
View File

@ -141,7 +141,7 @@ This function mirrors the setup function, and is run once during the node daemon
This function is run each time the plugin is called during a keepalive. It performs the main work of the plugin before returning the end result in a specific format. This function is run each time the plugin is called during a keepalive. It performs the main work of the plugin before returning the end result in a specific format.
Note that this function runs once for each keepalive, which by default is every 5 seconds. It is thus important to keep the runtime as short as possible and avoid doing complex calculations, file I/O, etc. during the plugin run. Do as much as possible in the setup function to keep the run function as quick as possible. Note that this function runs once for each keepalive, which by default is every 5 seconds. It is thus important to keep the runtime as short as possible and avoid doing complex calculations, file I/O, etc. during the plugin run. Do as much as possible in the setup function to keep the run function as quick as possible. A good safe maximum time for any plugin (e.g. if implementing an internal timeout) is 2 seconds.
What happens during the run function is of course completely up to the plugin, but it must return a standardized set of details upon completing the run. What happens during the run function is of course completely up to the plugin, but it must return a standardized set of details upon completing the run.

2
node-daemon/plugins/ipmi
View File

@ -74,7 +74,7 @@ class MonitoringPluginScript(MonitoringPlugin):
ipmi_password = self.config["ipmi_password"] ipmi_password = self.config["ipmi_password"]
retcode, _, _ = run_os_command( retcode, _, _ = run_os_command(
f"/usr/bin/ipmitool -I lanplus -H {ipmi_hostname} -U {ipmi_username} -P {ipmi_password} chassis power status", f"/usr/bin/ipmitool -I lanplus -H {ipmi_hostname} -U {ipmi_username} -P {ipmi_password} chassis power status",
timeout=1 timeout=2
) )
if retcode > 0: if retcode > 0: