Add safety to removal of legacy configs

This conditional will ensure that, the first time pvc.conf is installed
(or, subsequent times, until it stabilizes), the legacy configs will not
be removed. Then, on the next run in which pvc.conf does not change,
they will be removed.

This should provide a safety valve during a 0.9.83 update with the
update-pvc-daemons playbook: if the update succeeds, on the next run,
the legacy configs will be purged; otherwise, they will still be present
and can be used for fallback just in case.

This probably isn't needed, but just in case I'd rather be safe.

roles/pvc/tasks/autobackup/disable.yml

@@ -14,7 +14,6 @@
     dest: "{{ item }}"
     state: absent
   loop:
-    - /etc/pvc/autobackup.yaml
     - /etc/systemd/system/pvc-autobackup-normal.timer
     - /etc/systemd/system/pvc-autobackup-normal.service
     - /etc/systemd/system/pvc-autobackup-full.timer

roles/pvc/tasks/autobackup/enable.yml

@@ -8,11 +8,6 @@
     - pvc_autobackup.auto_mount.enabled is defined and pvc_autobackup.auto_mount.enabled
     - pvc_autobackup.auto_mount.packages is defined and pvc_autobackup.auto_mount.packages
 
-- name: install autobackup YAML configuration
-  template:
-    src: "autobackup/autobackup.yaml.j2"
-    dest: "/etc/pvc/autobackup.yaml"
-
 - name: install autobackup normal systemd units
   template:
     src: "autobackup/pvc-autobackup-normal.{{ item }}.j2"

roles/pvc/tasks/pvc/main.yml

@@ -29,11 +29,12 @@
 
 - name: install pvc daemon configuration
   template:
-    src: pvc/{{ item }}.j2
+    src: "pvc/{{ item }}.j2"
-    dest: /etc/pvc/{{ item }}
+    dest: "/etc/pvc/{{ item }}"
     mode: 0640
   with_items:
     - pvc.conf
+  register: new_daemon_config
 
 - name: remove obsolete pvc daemon configurations
   file:
@@ -43,6 +44,12 @@
     - pvcnoded.yaml
     - pvcapid.yaml
     - autobackup.yaml
+  # Only apply this task when the new daemon config has NOT changed.
+  # In practice, this means that the first time pvc.conf is written,
+  # the old configs will NOT be purged. Then, the next time this is
+  # run (presuming no fundamental changes happen to that config),
+  # they will be removed. Provides safety in case of a failed update.
+  when: not new_daemon_config.changed
 
 - name: install API SSL certificate file
   copy: