From 91b5cb6ba22822b6213a58805e79a5c150791541 Mon Sep 17 00:00:00 2001
From: "Joshua M. Boniface" <joshua@boniface.me>
Date: Fri, 1 Sep 2023 15:42:25 -0400
Subject: [PATCH] Adjust comments and IPMI value

---
 group_vars/default/base.yml | 9 ++++++---
 group_vars/default/pvc.yml  | 6 +++---
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/group_vars/default/base.yml b/group_vars/default/base.yml
index 614b95e..4289d0d 100644
--- a/group_vars/default/base.yml
+++ b/group_vars/default/base.yml
@@ -36,17 +36,20 @@ ipmi:
       password: ""
   hosts:
     "pvchv1":
-      hostname: pvchv1-lom
+      hostname: pvchv1-lom      # A valid short name (e.g. from /etc/hosts) or an FQDN must be
+                                # used here; PVC connects to this *hostname* for fencing.
       address: 192.168.100.101
       netmask: 255.255.255.0
       gateway: 192.168.100.1
     "pvchv2":
-      hostname: pvchv2-lom
+      hostname: pvchv2-lom      # A valid short name (e.g. from /etc/hosts) or an FQDN must be
+                                # used here; PVC connects to this *hostname* for fencing.
       address: 192.168.100.102
       netmask: 255.255.255.0
       gateway: 192.168.100.1
     "pvchv3":
-      hostname: pvchv3-lom
+      hostname: pvchv3-lom      # A valid short name (e.g. from /etc/hosts) or an FQDN must be
+                                # used here; PVC connects to this *hostname* for fencing.
       address: 192.168.100.103
       netmask: 255.255.255.0
       gateway: 192.168.100.1
diff --git a/group_vars/default/pvc.yml b/group_vars/default/pvc.yml
index bdaeab4..6cf03d9 100644
--- a/group_vars/default/pvc.yml
+++ b/group_vars/default/pvc.yml
@@ -93,7 +93,7 @@ pvc_nodes:
     upstream_ip: "192.168.100.11"
     cluster_ip: "10.0.0.1"
     storage_ip: "10.0.1.1"
-    ipmi_host: "{{ ipmi['hosts']['pvchv1']['hostname'] }}.{{ local_domain }}" # Note the hostname in here
+    ipmi_host: "{{ ipmi['hosts']['pvchv1']['hostname'] }}" # Note the node hostname key in here
     ipmi_user: "{{ ipmi['users']['pvc']['username'] }}"
     ipmi_password: "{{ ipmi['users']['pvc']['password'] }}"
   - hostname: "pvchv2"
@@ -103,7 +103,7 @@ pvc_nodes:
     upstream_ip: "192.168.100.12"
     cluster_ip: "10.0.0.2"
     storage_ip: "10.0.1.2"
-    ipmi_host: "{{ ipmi['hosts']['pvchv2']['hostname'] }}.{{ local_domain }}" # Note the hostname in here
+    ipmi_host: "{{ ipmi['hosts']['pvchv2']['hostname'] }}" # Note the node hostname key in here
     ipmi_user: "{{ ipmi['users']['pvc']['username'] }}"
     ipmi_password: "{{ ipmi['users']['pvc']['password'] }}"
   - hostname: "pvchv3"
@@ -113,7 +113,7 @@ pvc_nodes:
     upstream_ip: "192.168.100.13"
     cluster_ip: "10.0.0.3"
     storage_ip: "10.0.1.3"
-    ipmi_host: "{{ ipmi['hosts']['pvchv3']['hostname'] }}.{{ local_domain }}" # Note the hostname in here
+    ipmi_host: "{{ ipmi['hosts']['pvchv3']['hostname'] }}" # Note the node hostname key in here
     ipmi_user: "{{ ipmi['users']['pvc']['username'] }}"
     ipmi_password: "{{ ipmi['users']['pvc']['password'] }}"